mapleFU commented on code in PR #14351: URL: https://github.com/apache/arrow/pull/14351#discussion_r1004717971
########## cpp/src/arrow/util/crc32.cc: ########## @@ -0,0 +1,961 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: > If non-trivial changes were made to the code then it should stay in `arrow/util`, IMHO. Code in `arrow/vendored` should be mostly identical to upstream and easily updateable. Hi pitrou, my updates is: 1. changing it's `ENDIAN` to using arrows `ARROW_LITTLE_ENDIAN` 2. using `arrow::bit_util::ByteSwap` rather than it's `swap` 3. remove the code about `__optimize__` Should I just keep it here or put it in `vendor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
