alamb commented on code in PR #3907:
URL: https://github.com/apache/arrow-datafusion/pull/3907#discussion_r1004721301
##########
datafusion/proto/src/bytes/mod.rs:
##########
@@ -132,37 +136,41 @@ pub fn logical_plan_to_bytes_with_extension_codec(
/// Deserialize a LogicalPlan from json
#[cfg(feature = "json")]
-pub fn logical_plan_from_json(json: &str, ctx: &SessionContext) ->
Result<LogicalPlan> {
+pub async fn logical_plan_from_json(
+ json: &str,
+ ctx: &SessionContext,
+) -> Result<LogicalPlan> {
let back: protobuf::LogicalPlanNode = serde_json::from_str(json)
.map_err(|e| DataFusionError::Plan(format!("Error serializing plan:
{}", e)))?;
let extension_codec = DefaultExtensionCodec {};
- back.try_into_logical_plan(ctx, &extension_codec)
+ back.try_into_logical_plan(ctx, &extension_codec).await
}
/// Deserialize a LogicalPlan from bytes
-pub fn logical_plan_from_bytes(
+pub async fn logical_plan_from_bytes(
Review Comment:
To follow up -- becomes `async` so that a table provider can be
instantiated. This table provider, such as delta-rs, might have to do remote IO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
