alamb commented on code in PR #3943:
URL: https://github.com/apache/arrow-datafusion/pull/3943#discussion_r1004918870
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -834,6 +840,7 @@ enum PrimitiveScalarType{
BINARY = 25;
LARGE_BINARY = 26;
+ FIXED_SIZE_BINARY = 29;
Review Comment:
I removed the duplication with PrimitiveScalarType and `ScalarValue` in
https://github.com/apache/arrow-datafusion/commit/54d2870a56d8d8f914a617a7e2d52e387ef5dba2
so when you are resolving the merge conflict you should be able to just remove
this code
##########
datafusion/proto/src/lib.rs:
##########
@@ -556,6 +556,11 @@ mod roundtrip_tests {
Field::new("a", DataType::Boolean, false),
]),
),
+ ScalarValue::FixedSizeBinary(
+ b"bar".to_vec().len() as i32,
+ Some(b"bar".to_vec()),
+ ),
+ ScalarValue::FixedSizeBinary(0, None),
Review Comment:
I suggest adding a None case for non zero length as well
```suggestion
ScalarValue::FixedSizeBinary(0, None),
ScalarValue::FixedSizeBinary(5, None),
```
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -1064,10 +1064,13 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
Value::LargeBinaryValue(s.to_owned())
})
}
- scalar::ScalarValue::FixedSizeBinary(_, _) => {
- return Err(Error::General(
- "FixedSizeBinary is not yet implemented".to_owned(),
- ));
+ scalar::ScalarValue::FixedSizeBinary(length, val) => {
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
