pier-oliviert opened a new issue, #2935:
URL: https://github.com/apache/arrow-rs/issues/2935

   **Which part is this question about**
   <!--
   Is it code base, library api, documentation or some other part?
   -->
   I was reading comments surrounding the `SerializedFileWriter` code as I was 
implementing the writer on a codebase I'm working on and noticed this comment: 
   > Can be called multiple times. It is up to implementation to either result 
in
       no-op, or return an `Err` for subsequent calls.
   
   
https://github.com/apache/arrow-rs/blob/master/parquet/src/file/writer.rs#L180-L181
   
   **Describe your question**
   <!--
   A clear and concise description of what the question is.
   -->
   The code itself is clear enough to understand what is going on but I noted 
that the signature consumes `self` which makes me think that it's not really 
possible, in general, to call this method twice since `self` will be consumed 
and is not included in `FileMetaData`.
   
   Should the comment be modified? Or am I missing something else with regards 
to the writer. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to