jhorstmann commented on code in PR #2932:
URL: https://github.com/apache/arrow-rs/pull/2932#discussion_r1005422815


##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -3853,8 +3853,8 @@ mod tests {
         let b = cast(&array, &DataType::Utf8).unwrap();
         let c = b.as_any().downcast_ref::<StringArray>().unwrap();
         assert_eq!(&DataType::Utf8, c.data_type());
-        assert_eq!("1997-05-19 00:00:00.005", c.value(0));
-        assert_eq!("2018-12-25 00:00:00.001", c.value(1));
+        assert_eq!("1997-05-19 00:00:00.005 +00:00", c.value(0));
+        assert_eq!("2018-12-25 00:00:00.001 +00:00", c.value(1));

Review Comment:
   That looks like [rfc3339 
format](https://www.rfc-editor.org/rfc/rfc3339#section-5.6), which is probably 
the most common or standardized format.
   
   [`chrono` has a separate function for this 
format](https://docs.rs/chrono/latest/chrono/struct.DateTime.html#method.to_rfc3339_opts)
 which also allows specifying how many fractional digits you want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to