jorgecarleitao commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r501788233
##########
File path: rust/datafusion/src/test/mod.rs
##########
@@ -135,6 +135,13 @@ pub fn format_batch(batch: &RecordBatch) -> Vec<String> {
}
let array = batch.column(column_index);
match array.data_type() {
+ DataType::Utf8 => s.push_str(
+ array
+ .as_any()
+ .downcast_ref::<array::StringArray>()
+ .unwrap()
+ .value(row_index),
+ ),
Review comment:
I think that `count(distinct)` should be null when all entries are null,
for consistency with `count`. I do not think that this blocks this, though. It
is an edge case IMO.
##########
File path: rust/datafusion/src/test/mod.rs
##########
@@ -135,6 +135,13 @@ pub fn format_batch(batch: &RecordBatch) -> Vec<String> {
}
let array = batch.column(column_index);
match array.data_type() {
+ DataType::Utf8 => s.push_str(
+ array
+ .as_any()
+ .downcast_ref::<array::StringArray>()
+ .unwrap()
+ .value(row_index),
+ ),
Review comment:
I think that `count(distinct)` should be null when all entries are null,
for consistency with `count`. I do not think that it blocks this, though. It is
an edge case IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
