crepererum commented on code in PR #3970:
URL: https://github.com/apache/arrow-datafusion/pull/3970#discussion_r1005793121
##########
datafusion/proto/src/bytes/mod.rs:
##########
@@ -84,7 +87,45 @@ impl Serializeable for Expr {
DataFusionError::Plan(format!("Error encoding protobuf as bytes:
{}", e))
})?;
- Ok(buffer.into())
+ let bytes: Bytes = buffer.into();
+
+ // the produced byte stream may lead to "recursion limit" errors, see
+ // https://github.com/apache/arrow-datafusion/issues/3968
+ // Until the underlying prost issue (
https://github.com/tokio-rs/prost/issues/736 ) is fixed, we try to
+ // deserialize the data here and check for errors.
+ //
+ // Need to provide some placeholder registry because the stream may
contain UDFs
+ struct PlaceHolderRegistry;
+
+ impl FunctionRegistry for PlaceHolderRegistry {
Review Comment:
:see_no_evil:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
