avantgardnerio commented on PR #3955: URL: https://github.com/apache/arrow-datafusion/pull/3955#issuecomment-1292184021
> the interface of creating the logical plan should be serialize API I have the unfortunate tendency to agree with @yahoNanJing here... see fun examples like the log4j CVE and Java's famous [URL.equals()](https://news.ycombinator.com/item?id=21765788) examples of abuse of network access in parsing logic. That's why I originally spent so much time working on the separate `async fn create()` and `fn with_schema()` functions. It was very convenient to switch this to async, but from a principled perspective I think it's the wrong move. I can work @houqp and the folks over at `delta-rs` to serde the whole `DeltaTable` and `ObjectStore`. Since that PR is already working though, it would be nice to have some time to verify the assumption that the issue is resolvable before merging this PR. Thoughts @andygrove and @alamb ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
