NGA-TRAN commented on code in PR #3975:
URL: https://github.com/apache/arrow-datafusion/pull/3975#discussion_r1006045675
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -489,6 +496,196 @@ impl InListExpr {
contains_null
))
}
+
+ fn evaluate_non_dict(
Review Comment:
This is just a refactor to move all available on into this function so it
can be reused with Dictionary data
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -714,188 +912,31 @@ impl PhysicalExpr for InListExpr {
};
match value_data_type {
- DataType::Float32 => {
Review Comment:
This is the moved code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
