alamb commented on issue #3152:
URL: 
https://github.com/apache/arrow-datafusion/issues/3152#issuecomment-1292654025

   > Before opening pr, I want to be sure that this sample is implemented 
correctly. I added this function:
   
   Thanks @retikulum  -- that looks good to me
   
   
   What I would suggest is doing this in a series of smaller PRs -- perhaps add 
a few functions like `as_int32_array`, `as_uint32_array`, etc and consolidate 
some of the uses.
   
   That way we can then get feedback from the wider community before you spend 
a large amount of your time changing the entire codebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to