alamb commented on code in PR #3969:
URL: https://github.com/apache/arrow-datafusion/pull/3969#discussion_r1006939198
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -145,4 +145,26 @@ impl PhysicalExpr for ScalarFunctionExpr {
let fun = self.fun.as_ref();
(fun)(&inputs)
}
+
+ fn children(&self) -> Vec<Arc<dyn PhysicalExpr>> {
+ self.args.clone()
+ }
+
+ fn with_new_children(
+ self: Arc<Self>,
+ children: Vec<Arc<dyn PhysicalExpr>>,
+ ) -> Result<Arc<dyn PhysicalExpr>> {
+ Ok(Arc::new(ScalarFunctionExpr::new(
+ &self.name,
+ self.fun.clone(),
+ children,
+ self.return_type(),
+ )))
+ }
+}
+
+impl PartialEq<dyn Any> for ScalarFunctionExpr {
+ fn eq(&self, _other: &dyn Any) -> bool {
+ false
Review Comment:
Comparing name, args and return type seems like a pretty good comparison to
me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
