pitrou commented on a change in pull request #8403:
URL: https://github.com/apache/arrow/pull/8403#discussion_r502044409
##########
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##########
@@ -2689,6 +2689,26 @@ TEST(TestArrowReadWrite, DictionaryColumnChunkedWrite) {
::arrow::AssertTablesEqual(*expected_table, *result, false);
}
+TEST(TestArrowReadWrite, NonUniqueDictionaryValues) {
+ // ARROW-10237
+ auto dict_with_dupes = ArrayFromJSON(::arrow::utf8(), R"(["a", "a", "b"])");
+ auto indices = ArrayFromJSON(::arrow::int32(), R"([0, 1, 0, 1])");
Review comment:
You might want to check all possible index values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
