alamb commented on code in PR #2933:
URL: https://github.com/apache/arrow-rs/pull/2933#discussion_r1007300508
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -51,7 +55,11 @@ runs:
shell: bash
run: |
echo "Installing ${{ inputs.rust-version }}"
- rustup toolchain install ${{ inputs.rust-version }}
+ rustup toolchain install ${{ inputs.rust-version }} --target ${{
inputs.target }}
rustup default ${{ inputs.rust-version }}
- rustup target add wasm32-unknown-unknown
- echo "CARGO_TARGET_DIR=/github/home/target" >> $GITHUB_ENV
+ - name: Disable debuginfo generation
Review Comment:
```suggestion
- name: Disable debuginfo generation
# Disable full debug symbol generation to speed up CI build and keep
memory down
# "1" means line tables only, which is useful for panic tracebacks.
```
I think the rationale is important so it doesn't get lost accidentally along
the way
##########
.github/workflows/parquet.yml:
##########
@@ -93,35 +79,42 @@ jobs:
# 3. compiles with just arrow feature
# 3. compiles with all features
- name: Check compilation
- run: |
- cargo check -p parquet
+ run: cargo check -p parquet
- name: Check compilation --no-default-features
- run: |
- cargo check -p parquet --no-default-features
+ run: cargo check -p parquet --no-default-features
- name: Check compilation --no-default-features --features arrow
- run: |
- cargo check -p parquet --no-default-features --features arrow
+ run: cargo check -p parquet --no-default-features --features arrow
- name: Check compilation --no-default-features --all-features
- run: |
- cargo check -p parquet --all-features
+ run: cargo check -p parquet --all-features
- name: Check compilation --all-targets
- run: |
- cargo check -p parquet --all-targets
+ run: cargo check -p parquet --all-targets
- name: Check compilation --all-targets --no-default-features
- run: |
- cargo check -p parquet --all-targets --no-default-features
+ run: cargo check -p parquet --all-targets --no-default-features
- name: Check compilation --all-targets --no-default-features
--features arrow
- run: |
- cargo check -p parquet --all-targets --no-default-features
--features arrow
+ run: cargo check -p parquet --all-targets --no-default-features
--features arrow
- name: Check compilation --all-targets --all-features
- run: |
- cargo check -p parquet --all-targets --all-features
+ run: cargo check -p parquet --all-targets --all-features
- name: Check compilation --all-targets --no-default-features
--features json
- run: |
- cargo check -p parquet --all-targets --no-default-features
--features json
- - name: Check compilation wasm32-unknown-unknown
- run: |
- cargo check -p parquet --no-default-features --features
cli,snap,flate2,brotli --target wasm32-unknown-unknown
+ run: cargo check -p parquet --all-targets --no-default-features
--features json
+
+ # test the parquet crate builds against wasm32 in stable rust
Review Comment:
this is a new check, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
