tustvold commented on code in PR #3987:
URL: https://github.com/apache/arrow-datafusion/pull/3987#discussion_r1007334088
##########
datafusion/proto/Cargo.toml:
##########
@@ -55,5 +55,6 @@ doc-comment = "0.3"
tokio = "1.18"
[build-dependencies]
-pbjson-build = { version = "0.5" }
-prost-build = { version = "0.11.1" }
+# Pin these dependencies so that the generated output is deterministic
+pbjson-build = { version = "=0.5.1" }
Review Comment:
> We would start seeing local changes in our checkouts again
As this wouldn't be correlated with someone making a change to the proto
definitions I think this could be surprising. What would more likely happen is
their local lockfile will hold back the upgrade, then they will get strange CI
failures. If they then check in the proto files, people will then get local
changes until their lockfile is updated... Basically a bit of a mess
:sweat_smile:
I don't like this either, checking in this code feels wrong, but I'm at a
loss as to how to make this work better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
