tustvold commented on code in PR #2939:
URL: https://github.com/apache/arrow-rs/pull/2939#discussion_r1007374966
##########
arrow/src/util/display.rs:
##########
@@ -190,14 +191,37 @@ macro_rules! make_string_datetime {
} else {
array
.value_as_datetime($row)
- .map(|d| d.to_string())
+ .map(|d| format!("{:?}", d))
.unwrap_or_else(|| "ERROR CONVERTING DATE".to_string())
};
Ok(s)
}};
}
+macro_rules! make_string_datetime_with_tz {
+ ($array_type:ty, $tz_string: ident, $column: ident, $row: ident) => {{
+ let array = $column.as_any().downcast_ref::<$array_type>().unwrap();
+
+ let s = if array.is_null($row) {
+ "".to_string()
+ } else {
+ match $tz_string.parse::<Tz>() {
Review Comment:
In general this display code is very inefficient, I think there is a broader
issue to clean it up.
See the disclaimer on
https://docs.rs/arrow/latest/arrow/util/display/fn.array_value_to_string.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
