alamb commented on PR #3903: URL: https://github.com/apache/arrow-datafusion/pull/3903#issuecomment-1294986422
> I'm OK to merge the PR. But we might need a following PR to add a new rule to simply expressions before translate the logic Filter to physical FilterExec. I double checked @mingmwang This code is called as part of `FilterPushdown` https://github.com/apache/arrow-datafusion/blob/318b4ad56c826b317b0201f7031a47609ad215b5/datafusion/optimizer/src/optimizer.rs#L174 And then simplification is then called https://github.com/apache/arrow-datafusion/blob/318b4ad56c826b317b0201f7031a47609ad215b5/datafusion/optimizer/src/optimizer.rs#L178-L183 so I think the simplifications should happen before physical planning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
