jackwener commented on PR #3972: URL: https://github.com/apache/arrow-datafusion/pull/3972#issuecomment-1295071622
> The Trait `TreeNodeRewritable` is quite general, It does not have any assumption on the Tree Node type. Implementations just need to implement one method `map_children()`. And It also support rewriting using Visitors which can get ride of some clone() and can do more things in one tree walk(For example collect necessary context information and do rewriting, it's hybird of PostOrder and PreOder Tree traversal) This job is great. It will improve optimizer well and is overall compatible. The trouble may lie in how to deal with the rules that currently exist. And I think we can create a new optimizer struct and gradually migrate the rules. I find these code don't exist in master, Looking forward to your PR, @mingmwang thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
