Dandandan commented on code in PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000#discussion_r1008459727
##########
datafusion/core/src/physical_optimizer/hash_build_probe_order.rs:
##########
@@ -174,6 +174,13 @@ impl PhysicalOptimizerRule for HashBuildProbeOrder {
*hash_join.partition_mode(),
hash_join.null_equals_null(),
)?;
+ if matches!(
Review Comment:
Indeed. I figured it could be added later when RightAnti is implemented. I
will add a note to the ticket.
One thing I also observed is that adding the projection for other types
wouldn't be needed if we would update the join columns itself instead of fixing
it afterwards, but that requires some more plumbing to get right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
