aucahuasi commented on code in PR #14082:
URL: https://github.com/apache/arrow/pull/14082#discussion_r1008585496
##########
cpp/src/arrow/flight/sql/server.h:
##########
@@ -686,50 +686,50 @@ class ARROW_FLIGHT_SQL_EXPORT SqlSchema {
public:
/// \brief Get the Schema used on GetCatalogs response.
/// \return The default schema template.
- static std::shared_ptr<Schema> GetCatalogsSchema();
+ static const std::shared_ptr<Schema>& GetCatalogsSchema();
Review Comment:
Why we are changing these functions to return const references?
I think that won't increase the reference counter and can cause potential
problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
