andygrove commented on code in PR #4015:
URL: https://github.com/apache/arrow-datafusion/pull/4015#discussion_r1008758533
##########
benchmarks/src/bin/tpch.rs:
##########
@@ -829,113 +618,140 @@ mod tests {
Ok(str)
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q1() -> Result<()> {
+ async fn verify_q1() -> Result<()> {
verify_query(1).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q2() -> Result<()> {
+ async fn verify_q2() -> Result<()> {
verify_query(2).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q3() -> Result<()> {
+ async fn verify_q3() -> Result<()> {
verify_query(3).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q4() -> Result<()> {
+ async fn verify_q4() -> Result<()> {
verify_query(4).await
}
+ #[cfg(feature = "ci")]
#[tokio::test]
- async fn q5() -> Result<()> {
+ async fn verify_q5() -> Result<()> {
verify_query(5).await
}
+ #[cfg(feature = "ci")]
+ #[ignore] // TODO produces wrong result
#[tokio::test]
- async fn q6() -> Result<()> {
+ async fn verify_q6() -> Result<()> {
Review Comment:
https://github.com/apache/arrow-datafusion/issues/4024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
