andygrove commented on code in PR #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037#discussion_r1008920714
##########
benchmarks/src/tpch.rs:
##########
@@ -38,12 +40,17 @@ pub const TPCH_TABLES: &[&str] = &[
"part", "supplier", "partsupp", "customer", "orders", "lineitem",
"nation", "region",
];
+fn decimal_type(_p: u8, _s: u8) -> DataType {
+ // TODO use decimal_type(p, s) once Decimal is fully supported
+ // https://github.com/apache/arrow-datafusion/issues/3523
+ DataType::Float64
+}
Review Comment:
We could also add a CLI option to switch between float and decimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
