kou commented on code in PR #14551:
URL: https://github.com/apache/arrow/pull/14551#discussion_r1008921525
##########
dev/release/verify-release-candidate.sh:
##########
@@ -326,7 +326,13 @@ install_nodejs() {
PROFILE=/dev/null bash
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
- nvm install --lts
+ min_glibc_version_for_node_18_or_greater=2.25
+ glibc_version=$(ldd --version | grep ldd | rev | cut --delimiter=' ' -f1
| rev)
+ if [ -n "${glibc_version}" -ge
"${min_glibc_version_for_node_18_or_greater}" ]; then
+ nvm install --lts
+ else
+ nvm install --lts=Gallium
+ fi
Review Comment:
This code is also used by macOS. So using `ldd` isn't a good idea.
How about always using `nvm install --lts=Gallium` or detecting CentOS 7 (`[
-f /etc/centos-release-upstream ]`) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
