viirya commented on code in PR #2940:
URL: https://github.com/apache/arrow-rs/pull/2940#discussion_r1008945940
##########
arrow/src/compute/kernels/boolean.rs:
##########
@@ -470,27 +473,19 @@ pub fn is_not_null(input: &dyn Array) ->
Result<BooleanArray> {
/// Copies original array, setting null bit to true if a secondary comparison
boolean array is set to true.
Review Comment:
Not related to the change, but I got confused while reading this.
Based on following comment:
```
// left=1 right=1 & comp=true output bitmap=null
// left=1 right=1 & comp=false output bitmap=set
```
I think that if the boolean array is set to true, null bit will be set to
false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
