tustvold commented on code in PR #4039:
URL: https://github.com/apache/arrow-datafusion/pull/4039#discussion_r1009009343
##########
datafusion/expr/src/function.rs:
##########
@@ -219,7 +219,7 @@ pub fn return_type(
}
BuiltinScalarFunction::Now => Ok(DataType::Timestamp(
TimeUnit::Nanosecond,
- Some("UTC".to_owned()),
+ Some("+00:00".to_owned()),
Review Comment:
This change is necessary because by default (without the chrono-tz feature)
arrow-rs doesn't know how to interpret this timezone. With the recent
improvements to timezone handling, it now complains - (it prints "Unknown
Timezone" when rending the timestamps). _TBC this is an improvement over
silently ignoring the timezone which it did before_
FYI @waitingkuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
