thisisnic commented on code in PR #14530:
URL: https://github.com/apache/arrow/pull/14530#discussion_r1009402154
##########
r/src/altrep.cpp:
##########
@@ -1098,9 +1098,9 @@ void test_arrow_altrep_set_string_elt(sexp x, int i,
std::string value) {
}
// [[arrow::export]]
-logicals test_arrow_altrep_is_materialized(sexp x) {
+sexp test_arrow_altrep_is_materialized(sexp x) {
Review Comment:
Is there generally a heuristic you use for when to use `SEXP` versus the
cpp11 version of the variable, and vice versa?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
