WillAyd opened a new pull request, #14555:
URL: https://github.com/apache/arrow/pull/14555

   @jorisvandenbossche 
   
   I've commented out a few things that aren't working, which I'd summarize as:
   
   1. Null Handling - by default numpy's intersect1d discards NaN, but here 
NULL would be returned. Its worth discussing whether we want NULL to be 
included here or not; I _think_ we should and give the user the ability to 
control where it appears via SortOptions
   2. Boolean Type - had issues with the call to Buffer::Wrap complaining that 
the `const` qualifer on the vector was being discarded. Didn't fully 
troubleshoot this, but wasn't sure an intersect on BooleanTypes is all that 
useful either
   3. Temporal Types - got a segfault that I need to trouble shoot. 
   
   There likely is a better way of constructing the result that could naturally 
solve issues 2 and 3 above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to