alamb commented on PR #3994: URL: https://github.com/apache/arrow-datafusion/pull/3994#issuecomment-1298594090
Thank you @yuuch 😍 -- Love the cleanup! It looks like one of the tests is failing -- can you please update the plan? https://github.com/apache/arrow-datafusion/actions/runs/3352036848/jobs/5558342674 ``` ---- sql::subqueries::tpch_q2_correlated stdout ---- thread 'sql::subqueries::tpch_q2_correlated' panicked at 'assertion failed: `(left == right)` left: `"Sort: supplier.s_acctbal DESC NULLS FIRST, nation.n_name ASC NULLS LAST, supplier.s_name ASC NULLS LAST, part.p_partkey ASC NULLS LAST\n Projection: supplier.s_acctbal, supplier.s_name, nation.n_name, part.p_partkey, part.p_mfgr, supplier.s_address, supplier.s_phone, supplier.s_comment\n Inner Join: part.p_partkey = __sq_1.ps_partkey, partsupp.ps_supplycost = __sq_1.__value\n Inner Join: nation.n_regionkey = region.r_regionkey\n Inner Join: supplier.s_nationkey = nation.n_nationkey\n Inner Join: part.p_partkey = partsupp.ps_partkey, supplier.s_suppkey = partsupp.ps_suppkey\n CrossJoin:\n Filter: part.p_size = Int32(15) AND part.p_type LIKE Utf8(\"%BRASS\")\n TableScan: part projection=[p_partkey, p_mfgr, p_type, p_size], partial_filters=[part.p_size = Int32(15), part.p_type LIKE Utf8(\"%BRASS\")]\n TableScan: supplier projection=[s_suppkey, s_name, s_address, s_nationkey, s_phone, s_acctbal, s_c omment]\n TableScan: partsupp projection=[ps_partkey, ps_suppkey, ps_supplycost]\n TableScan: nation projection=[n_nationkey, n_name, n_regionkey]\n Filter: region.r_name = Utf8(\"EUROPE\")\n TableScan: region projection=[r_regionkey, r_name], partial_filters=[region.r_name = Utf8(\"EUROPE\")]\n Projection: partsupp.ps_partkey, MIN(partsupp.ps_supplycost) AS __value, alias=__sq_1\n Aggregate: groupBy=[[partsupp.ps_partkey]], aggr=[[MIN(partsupp.ps_supplycost)]]\n Inner Join: nation.n_regionkey = region.r_regionkey\n Inner Join: supplier.s_nationkey = nation.n_nationkey\n Inner Join: partsupp.ps_suppkey = supplier.s_suppkey\n TableScan: partsupp projection=[ps_partkey, ps_suppkey, ps_supplycost]\n TableScan: supplier projection=[s_suppkey, s_name, s_address, s_nationkey, s_phone, s_acctbal, s_comment]\n TableScan: nation projection=[n_nationkey, n_name, n_region key]\n Filter: region.r_name = Utf8(\"EUROPE\")\n TableScan: region projection=[r_regionkey, r_name], partial_filters=[region.r_name = Utf8(\"EUROPE\")]"`, right: `"Sort: supplier.s_acctbal DESC NULLS FIRST, nation.n_name ASC NULLS LAST, supplier.s_name ASC NULLS LAST, part.p_partkey ASC NULLS LAST\n Projection: supplier.s_acctbal, supplier.s_name, nation.n_name, part.p_partkey, part.p_mfgr, supplier.s_address, supplier.s_phone, supplier.s_comment\n Inner Join: part.p_partkey = __sq_1.ps_partkey, partsupp.ps_supplycost = __sq_1.__value\n Inner Join: nation.n_regionkey = region.r_regionkey\n Inner Join: supplier.s_nationkey = nation.n_nationkey\n Inner Join: partsupp.ps_suppkey = supplier.s_suppkey\n Inner Join: part.p_partkey = partsupp.ps_partkey\n Filter: part.p_size = Int32(15) AND part.p_type LIKE Utf8(\"%BRASS\")\n TableScan: part projection=[p_partkey, p_mfgr, p_type, p_size], partial_filters=[part.p_size = Int32(15), part.p_type LIKE Utf8(\"%BRASS\")]\n TableScan: partsupp projection=[ps_partkey, ps_suppkey, ps_supplycost]\n TableScan: sup plier projection=[s_suppkey, s_name, s_address, s_nationkey, s_phone, s_acctbal, s_comment]\n TableScan: nation projection=[n_nationkey, n_name, n_regionkey]\n Filter: region.r_name = Utf8(\"EUROPE\")\n TableScan: region projection=[r_regionkey, r_name], partial_filters=[region.r_name = Utf8(\"EUROPE\")]\n Projection: partsupp.ps_partkey, MIN(partsupp.ps_supplycost) AS __value, alias=__sq_1\n Aggregate: groupBy=[[partsupp.ps_partkey]], aggr=[[MIN(partsupp.ps_supplycost)]]\n Inner Join: nation.n_regionkey = region.r_regionkey\n Inner Join: supplier.s_nationkey = nation.n_nationkey\n Inner Join: partsupp.ps_suppkey = supplier.s_suppkey\n TableScan: partsupp projection=[ps_partkey, ps_suppkey, ps_supplycost]\n TableScan: supplier projection=[s_suppkey, s_name, s_address, s_nationkey, s_phone, s_acctbal, s_comment]\n TableScan: nation projection=[n_nationkey, n_name, n_region key]\n Filter: region.r_name = Utf8(\"EUROPE\")\n TableScan: region projection=[r_regionkey, r_name], partial_filters=[region.r_name = Utf8(\"EUROPE\")]"`', datafusion/core/tests/sql/subqueries.rs:167:5 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
