yahoNanJing commented on code in PR #472:
URL: https://github.com/apache/arrow-ballista/pull/472#discussion_r1011096741
##########
ballista/scheduler/src/main.rs:
##########
@@ -250,15 +254,34 @@ async fn main() -> Result<()> {
let scheduling_policy: TaskSchedulingPolicy = opt.scheduler_policy;
let slots_policy: SlotsPolicy = opt.executor_slots_policy;
- let event_loop_buffer_size = opt.event_loop_buffer_size as usize;
+ let mut config_builder = SchedulerConfigBuilder::default()
+ .set(
+ BALLISTA_SCHEDULER_EVENT_LOOP_BUFFER_SIZE,
+ &opt.event_loop_buffer_size.to_string(),
+ )
+ .set(
+ BALLISTA_FINISHED_JOB_DATA_CLEANUP_DELAY_SECS,
+ &opt.finished_job_data_clean_up_interval_seconds.to_string(),
+ )
+ .set(
+ BALLISTA_FINISHED_JOB_STATE_CLEANUP_DELAY_SECS,
+ &opt.finished_job_state_clean_up_interval_seconds.to_string(),
+ );
Review Comment:
Thanks @andygrove for your comments. Agree with you. It's a bit over
designed. I'll change it back and use a normal struct to indicate the scheduler
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
