milesgranger commented on code in PR #14395:
URL: https://github.com/apache/arrow/pull/14395#discussion_r1011542779
##########
cpp/src/arrow/compute/kernels/scalar_nested_test.cc:
##########
@@ -116,6 +117,97 @@ TEST(TestScalarNested, ListElementInvalid) {
Raises(StatusCode::Invalid));
}
+void CheckListSlice(std::shared_ptr<Array> input, std::shared_ptr<Array>
expected,
+ const ListSliceOptions& args) {
+ ASSERT_OK_AND_ASSIGN(auto result, CallFunction("list_slice", {input},
&args));
+ ASSERT_EQ(result, expected);
Review Comment:
I've updated it now, but it fails with seemingly weird expected/actual
discrepancies. (the Python tests all pass)
But I'll poke around at this more
<details>
<summary>Example failures now</summary>
<br/>
Failed
Got:
[
[
[
3
],
[],
[],
null
],
[
[],
[],
null,
null
]
]
Expected:
[
[
[
3
]
],
[
[],
[],
null
]
]
---
Null counts differ. Expected -1 but was 2
Expected:
[
[]
]
Actual:
[
[],
[],
null,
null
]
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
