nealrichardson commented on PR #14553: URL: https://github.com/apache/arrow/pull/14553#issuecomment-1300404514
> Loving the refactor/cleanup! > > I also like the idea of renaming `build_expr()`...maybe `Expression$op_cast_common()` though to remind us all what it's doing? The cast to common type (`wrap_scalars()` but feel free to 🚲 🏠 a better name, it's not quite right) is accessible outside build_expr and is used in a couple of places. I think `Expression$op()` more accurately reflects what build_expr is now--it's essentially `Ops.Expression`, just factored out so that it can be used in `register_binding()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
