waitingkuo commented on code in PR #4069:
URL: https://github.com/apache/arrow-datafusion/pull/4069#discussion_r1012102733
##########
datafusion/sql/src/planner.rs:
##########
@@ -2451,6 +2458,84 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
self.statement_to_plan(rewrite.pop_front().unwrap())
}
+ fn set_variable_to_plan(
+ &self,
+ local: bool,
+ hivevar: bool,
+ variable: &ObjectName,
+ value: Vec<sqlparser::ast::Expr>,
+ ) -> Result<LogicalPlan> {
+ if local {
+ return Err(DataFusionError::NotImplemented(
+ "LOCAL is not supported".to_string(),
+ ));
+ }
+
+ if hivevar {
+ return Err(DataFusionError::NotImplemented(
+ "HIVEVAR is not supported".to_string(),
+ ));
+ }
+
+ let variable = variable.to_string();
+ let mut variable_lower = variable.to_lowercase();
+
+ if variable_lower == "timezone" || variable_lower == "time.zone" {
+ // we could introduce alias in OptionDefinition if this string
matching thing grows
+ variable_lower = "datafusion.execution.time_zone".to_string();
+ }
+
+ // we don't support change time zone until we complete time zone
related implementation
+ if variable_lower == "datafusion.execution.time_zone" {
+ return Err(DataFusionError::Plan(
+ "Changing Time Zone isn't supported yet".to_string(),
+ ));
+ }
+
+ // parse value string from Expr
+ let value_string = match &value[0] {
+ SQLExpr::Identifier(i) => i.to_string(),
+ SQLExpr::Value(v) => match v {
+ Value::SingleQuotedString(s) => s.to_string(),
+ Value::Number(_, _) | Value::Boolean(_) => v.to_string(),
+ Value::DoubleQuotedString(_)
+ | Value::EscapedStringLiteral(_)
+ | Value::NationalStringLiteral(_)
+ | Value::HexStringLiteral(_)
+ | Value::Null
+ | Value::Placeholder(_) => {
+ return Err(DataFusionError::Plan(format!(
+ "Unspported Value {}",
+ value[0]
+ )))
+ }
+ },
+ // for capture signed number e.g. +8, -8
+ SQLExpr::UnaryOp { op, expr } => match op {
+ UnaryOperator::Plus => format!("+{}", expr),
+ UnaryOperator::Minus => format!("-{}", expr),
Review Comment:
i'm not familiar with this yet, will try it and send a ticket or pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
