tustvold commented on code in PR #3002:
URL: https://github.com/apache/arrow-rs/pull/3002#discussion_r1012195743
##########
parquet/src/file/writer.rs:
##########
@@ -488,6 +499,11 @@ impl<'a> SerializedColumnWriter<'a> {
get_typed_column_writer_mut(&mut self.inner)
}
+ /// Returns a clone to a [`ColumnDescPtr`]
+ pub fn descriptor(&self) -> ColumnDescPtr {
Review Comment:
Returning &ColumnDescPtr would be more idiomatic so the caller can clone
only if they need to
##########
parquet/src/file/writer.rs:
##########
@@ -473,9 +479,14 @@ impl<'a> SerializedColumnWriter<'a> {
/// optional callback to be invoked on [`Self::close`]
pub fn new(
inner: ColumnWriter<'a>,
+ descriptor: ColumnDescPtr,
Review Comment:
This is a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
