mingmwang commented on code in PR #4043:
URL: https://github.com/apache/arrow-datafusion/pull/4043#discussion_r1012384969
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -186,13 +194,26 @@ impl AggregateExec {
let schema = Arc::new(schema);
+ let mut alias_map: HashMap<Column, Vec<Column>> = HashMap::new();
Review Comment:
This is to deal with the case that there are alias in the group exprs, in
this case we can not derive the output partitioning from the input/child
directly, need to take the alias into consideration. This is similar to the
`ProjectionExec`.
For example, the input has the output partitioning 'a', the `ProjectionExec`
or `AggregateExec` might have alias 'a as a1', the output partitioning of the
ProjectionExec or AggregateExec should be 'a1'.
`ProjectionExec` and `AggregateExec` will never change the real data
distribution, but need to respect the alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
