viirya commented on code in PR #3007:
URL: https://github.com/apache/arrow-rs/pull/3007#discussion_r1012481648
##########
arrow-array/src/cast.rs:
##########
@@ -98,52 +98,35 @@ macro_rules! downcast_integer {
/// `m` with the corresponding [`ArrowPrimitiveType`], followed by any
additional arguments
///
/// ```
-/// # use arrow_array::{downcast_primitive, ArrowPrimitiveType};
+/// # use arrow_array::{downcast_temporal, ArrowPrimitiveType};
/// # use arrow_schema::DataType;
///
-/// macro_rules! primitive_size_helper {
+/// macro_rules! temporal_size_helper {
/// ($t:ty, $o:ty) => {
/// std::mem::size_of::<<$t as ArrowPrimitiveType>::Native>() as $o
/// };
/// }
///
-/// fn primitive_size(t: &DataType) -> u8 {
-/// downcast_primitive! {
-/// t => (primitive_size_helper, u8),
+/// fn temporal_size(t: &DataType) -> u8 {
+/// downcast_temporal! {
+/// t => (temporal_size_helper, u8),
/// _ => u8::MAX
/// }
/// }
///
-/// assert_eq!(primitive_size(&DataType::Int32), 4);
-/// assert_eq!(primitive_size(&DataType::Int64), 8);
-/// assert_eq!(primitive_size(&DataType::Float16), 2);
+/// assert_eq!(temporal_size(&DataType::Date32), 4);
+/// assert_eq!(temporal_size(&DataType::Date64), 8);
/// ```
///
/// [`DataType`]: arrow_schema::DataType
#[macro_export]
-macro_rules! downcast_primitive {
+macro_rules! downcast_temporal {
($($data_type:expr),+ => ($m:path $(, $args:tt)*), $($($p:pat),+ =>
$fallback:expr $(,)*)*) => {
- $crate::downcast_integer! {
- $($data_type),+ => ($m $(, $args)*),
- $crate::repeat_pat!(arrow_schema::DataType::Float16,
$($data_type),+) => {
- $m!($crate::types::Float16Type $(, $args)*)
- }
- $crate::repeat_pat!(arrow_schema::DataType::Float32,
$($data_type),+) => {
- $m!($crate::types::Float32Type $(, $args)*)
- }
- $crate::repeat_pat!(arrow_schema::DataType::Float64,
$($data_type),+) => {
- $m!($crate::types::Float64Type $(, $args)*)
- }
- $crate::repeat_pat!(arrow_schema::DataType::Date32,
$($data_type),+) => {
- $m!($crate::types::Date32Type $(, $args)*)
- }
- $crate::repeat_pat!(arrow_schema::DataType::Date64,
$($data_type),+) => {
- $m!($crate::types::Date64Type $(, $args)*)
- }
+ match ($($data_type),+) {
$crate::repeat_pat!(arrow_schema::DataType::Time32(arrow_schema::TimeUnit::Second),
$($data_type),+) => {
$m!($crate::types::Time32SecondType $(, $args)*)
}
-
$crate::repeat_pat!(arrow_schema::DataType::Time32(arrow_schema::TimeUnit::Millisecond),
$($data_type),+) => {
+
$crate::repeat_pat!(arrow_schema::DataType::Time32(arrow_schema::TimeUnit::Microsecond),
$($data_type),+) => {
Review Comment:
nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
