yahoNanJing commented on code in PR #4043:
URL: https://github.com/apache/arrow-datafusion/pull/4043#discussion_r1012519437


##########
datafusion/core/src/physical_plan/projection.rs:
##########
@@ -51,6 +56,10 @@ pub struct ProjectionExec {
     schema: SchemaRef,
     /// The input plan
     input: Arc<dyn ExecutionPlan>,
+    /// The output ordering
+    output_ordering: Option<Vec<PhysicalSortExpr>>,
+    /// The alias map used to normalize out expressions like Partitioning and 
PhysicalSortExpr
+    alias_map: HashMap<Column, Vec<Column>>,

Review Comment:
   Better to add comments to indicate what does the key & value stand for.
   
   For my understanding, the key is the column in the input schema of this 
Projection operator. While the values are the columns in this output schema of 
this Projection operator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to