andygrove commented on code in PR #485:
URL: https://github.com/apache/arrow-ballista/pull/485#discussion_r1012941123
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -543,6 +543,30 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
})?;
Ok(Response::new(CancelJobResult { cancelled: true }))
}
+
+ async fn clean_job_data(
+ &self,
+ request: Request<CleanJobDataParams>,
+ ) -> Result<Response<CleanJobDataResult>, Status> {
+ let job_id = request.into_inner().job_id;
+ info!("Received clean data request for job {}", job_id);
+
+ self.query_stage_event_loop
+ .get_sender()
+ .map_err(|e| {
+ let msg = format!("Get query stage event loop error due to
{:?}", e);
+ error!("{}", msg);
+ Status::internal(msg)
Review Comment:
minor nit: we could introduce a function to create these `Status` messages
to avoid duplicating this block of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
