pgovind commented on a change in pull request #8404:
URL: https://github.com/apache/arrow/pull/8404#discussion_r502005704
##########
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##########
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
return false;
}
+
+ public static void Compare(Field expected, Field actual)
Review comment:
Does this method do the same thing that `Equals` does above?
##########
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##########
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
return false;
}
+
+ public static void Compare(Field expected, Field actual)
Review comment:
Is this method similar to `Equals` above?
##########
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##########
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
return false;
}
+
+ public static void Compare(Field expected, Field actual)
Review comment:
Isn't this method similar to `Equals` above? `Compare` could just call
through to `Equals` and assert if the return was false?
##########
File path: csharp/test/Apache.Arrow.Tests/FieldComparer.cs
##########
@@ -38,5 +39,26 @@ public static bool Equals(Field f1, Field f2)
}
return false;
}
+
+ public static void Compare(Field expected, Field actual)
Review comment:
Ah ok. Sad that we need to have 2 copies for this. But, it's in testing
code, so I'm not that concerned about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
