jorisvandenbossche commented on code in PR #14499:
URL: https://github.com/apache/arrow/pull/14499#discussion_r1013066869
##########
python/pyarrow/_fs.pyx:
##########
@@ -78,6 +78,12 @@ cdef CFileType _unwrap_file_type(FileType ty) except *:
assert 0
+def _file_type_to_string(ty):
+ # Python 3.11 changed str(IntEnum) to return the string representation
+ # of the integer value: https://github.com/python/cpython/issues/94763
+ return f"{ty.__class__.__name__}.{ty._name_}"
Review Comment:
While this is good fix to get the tests passing and the repr of `FileInfo`
working, we should maybe consider changing FileType to be a StrEnum instead?
(although I don't know if cython supports that)
Or to change the repr of `FileType` as well. As with the current change,
also the FileType repr on python 3.11 will no longer be informative (not just
the FileInfo repr)
(but this can certainly be left for a follow-up)
##########
dev/tasks/tasks.yml:
##########
@@ -498,7 +499,9 @@ tasks:
macos_deployment_target: "11.0"
artifacts:
- pyarrow-{no_rc_version}-{{ python_tag }}-{{ python_tag
}}-macosx_11_0_arm64.whl
+{% endfor %}
+{% for python_version, python_tag in [("3.9", "cp39"), ("3.10", "cp310")] %}
Review Comment:
I think we could also stop providing universal wheels altogether for new
pyarrow versions? (and not just stop providing them for the python 3.11 wheels?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
