mingmwang commented on code in PR #4043:
URL: https://github.com/apache/arrow-datafusion/pull/4043#discussion_r1013139898
##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -122,10 +122,20 @@ pub trait ExecutionPlan: Debug + Send + Sync {
/// have any particular output order here
fn output_ordering(&self) -> Option<&[PhysicalSortExpr]>;
- /// Specifies the data distribution requirements of all the
- /// children for this operator
- fn required_child_distribution(&self) -> Distribution {
- Distribution::UnspecifiedDistribution
+ /// Specifies the data distribution requirements for all the
+ /// children for this operator, By default it's
[[Distribution::UnspecifiedDistribution]] for each child,
+ fn required_input_distribution(&self) -> Vec<Distribution> {
Review Comment:
@alamb
How do you think, for leaf nodes, should we return an empty `vec![] `here or
return
`vec![Distribution::UnspecifiedDistribution] `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
