jonathanswenson commented on PR #14472: URL: https://github.com/apache/arrow/pull/14472#issuecomment-1302451601
@rok I could be way off base here -- does it need to be prefixed now when looking for the dylib? JNILoader seems to be looking for `libarrow_cdata_jni.dylib, but does it need to be either `aarch64/libarrow_cdata_jni.dylib` or `x86_64/libarrow_cdata.jni.dylib` (or the equivalent for the widows / linux shared libraries) In a previous step it is testing to see if the following shared libraries exist: ``` + test -f arrow/java-dist/x86_64/libarrow_orc_jni.so + test -f arrow/java-dist/x86_64/libarrow_cdata_jni.so + test -f arrow/java-dist/x86_64/libgandiva_jni.so + test -f arrow/java-dist/x86_64/libarrow_dataset_jni.so + test -f arrow/java-dist/x86_64/libplasma_java.so + test -f arrow/java-dist/x86_64/libarrow_cdata_jni.dylib + test -f arrow/java-dist/x86_64/libplasma_java.dylib + test -f arrow/java-dist/x86_64/libarrow_dataset_jni.dylib + test -f arrow/java-dist/x86_64/libgandiva_jni.dylib + test -f arrow/java-dist/x86_64/libarrow_orc_jni.dylib + test -f arrow/java-dist/aarch_64/libarrow_cdata_jni.dylib + test -f arrow/java-dist/aarch_64/libplasma_java.dylib + test -f arrow/java-dist/aarch_64/libarrow_dataset_jni.dylib + test -f arrow/java-dist/aarch_64/libgandiva_jni.dylib + test -f arrow/java-dist/aarch_64/libarrow_orc_jni.dylib + test -f arrow/java-dist/x86_64/arrow_cdata_jni.dll + test -f arrow/java-dist/x86_64/arrow_dataset_jni.dll + test -f arrow/java-dist/x86_64/arrow_orc_jni.dll ``` Now that there are two libarrow_cdata_jni.dylibs do we need to differentiate? In a successful run (from another branch or something) the list doesn't have those prefixes (because obviously you added them): https://github.com/ursacomputing/crossbow/actions/runs/3384176323/jobs/5621687808 ``` Run set -x + test -f arrow/java-dist/libarrow_cdata_jni.dylib + test -f arrow/java-dist/libarrow_cdata_jni.so + test -f arrow/java-dist/arrow_cdata_jni.dll + test -f arrow/java-dist/libarrow_dataset_jni.dylib + test -f arrow/java-dist/libarrow_dataset_jni.so + test -f arrow/java-dist/arrow_dataset_jni.dll + test -f arrow/java-dist/libarrow_orc_jni.dylib + test -f arrow/java-dist/libarrow_orc_jni.so + test -f arrow/java-dist/arrow_orc_jni.dll + test -f arrow/java-dist/libgandiva_jni.dylib + test -f arrow/java-dist/libgandiva_jni.so + test -f arrow/java-dist/libplasma_java.dylib + test -f arrow/java-dist/libplasma_java.so ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
