kou commented on code in PR #14570:
URL: https://github.com/apache/arrow/pull/14570#discussion_r1013385221
##########
dev/tasks/tasks.yml:
##########
@@ -157,6 +157,7 @@ groups:
- example-*
- wheel-*
- python-sdist
+ - r-binary-packages
Review Comment:
Do we need this?
I think that the `nightly` group isn't maintained (but misused: ARROW-18094).
##########
ci/scripts/install_sccache.sh:
##########
@@ -41,14 +41,22 @@ SCCACHE_ARCHIVE=sccache.tar.gz
# Download archive and checksum
curl -L $SCCACHE_URL --output $SCCACHE_ARCHIVE
curl -L $SCCACHE_URL.sha256 --output $SCCACHE_ARCHIVE.sha256
+echo " $SCCACHE_ARCHIVE" >> $SCCACHE_ARCHIVE.sha256
-echo "$(cat $SCCACHE_ARCHIVE.sha256) $SCCACHE_ARCHIVE" | sha256sum --check
--status
+SHA_ARGS="--check --status"
+
+# Busybox sha256sum uses different flags
+if sha256sum --version 2>&1 | grep -q BusyBox; then
+ SHA_ARGS="-sc"
+fi
+
+sha256sum $SHA_ARGS $SCCACHE_ARCHIVE.sha256
if [ ! -d $PREFIX ]; then
mkdir -p $PREFIX
fi
-tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory $PREFIX --wildcards
sccache*/sccache*
+tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory $PREFIX
--exclude="sccache*/*E*E*"
Review Comment:
Could you add an expected result with an example as comment?
This ignores `LICENSE` and `README.md` by `*E*E*`?
##########
dev/tasks/r/github.linux.cran.yml:
##########
@@ -44,7 +44,9 @@ jobs:
- name: Docker Run
shell: bash
- # setting ARROW_SOURCE_HOME='' here ensures that we use the cpp source
copied into tools/
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8)}}
+ # setting ARROW_SOURCE_HOME='' here ensures that we use the cpp
source copied into tools/
Review Comment:
```suggestion
# setting ARROW_SOURCE_HOME='' here ensures that we use the cpp
source copied into tools/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
