jorisvandenbossche commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r502406437
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -2200,7 +2196,7 @@ def test_write_dataset(tempdir):
dataset = ds.dataset(directory)
target = tempdir / 'single-directory-target'
- expected_files = [target / "dat_0.ipc", target / "dat_1.ipc"]
+ expected_files = [target / "part-0.feather"]
Review comment:
Why did this change to a single file? (the original has 2 files, I
expect the roundtrip to preserve those files)
##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -2258,11 +2254,6 @@ def test_write_dataset_use_threads(tempdir):
use_threads=False
)
- # check that all files are the same in both cases
- paths1 = [p.relative_to(target1) for p in target1.rglob("*")]
- paths2 = [p.relative_to(target2) for p in target2.rglob("*")]
- assert set(paths1) == set(paths2)
Review comment:
Why was this removed? (does it no longer hold?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
