liukun4515 commented on code in PR #4102:
URL: https://github.com/apache/arrow-datafusion/pull/4102#discussion_r1013579683
##########
datafusion/sql/src/planner.rs:
##########
@@ -2907,28 +2973,26 @@ pub fn convert_data_type(sql_type: &SQLDataType) ->
Result<DataType> {
}
}
-// Parse number in sql string, convert to Expr::Literal
-fn parse_sql_number(n: &str) -> Result<Expr> {
- // parse first as i64
- n.parse::<i64>()
- .map(lit)
- // if parsing as i64 fails try f64
- .or_else(|_| n.parse::<f64>().map(lit))
- .map_err(|_| {
- DataFusionError::from(ParserError(format!(
- "Cannot parse {} as i64 or f64",
- n
- )))
- })
-}
-
#[cfg(test)]
mod tests {
use super::*;
use datafusion_common::assert_contains;
use sqlparser::dialect::{Dialect, GenericDialect, HiveDialect,
MySqlDialect};
use std::any::Any;
+ #[test]
+ fn parse_decimals() {
+ let options = ParserOptions {
+ parse_float_as_decimal: true,
+ };
+ quick_test_with_options(
+ "SELECT 1, 1.0, 0.1, .1, 12.34",
+ "Projection: Int64(1), Decimal128(Some(10),2,1),
Decimal128(Some(1),2,1), Decimal128(Some(1),1,1), Decimal128(Some(1234),4,2)\
Review Comment:
we should try to use the min precision to represent the value in the decimal
literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
