jorisvandenbossche commented on code in PR #14395:
URL: https://github.com/apache/arrow/pull/14395#discussion_r1013853386
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2985,6 +2985,17 @@ def test_list_slice_output_variable(start, stop,
value_type, list_type):
assert pylist == expected
[email protected]("fixed_size_list", (True, False))
[email protected]("type", (
+ lambda: pa.list_(pa.struct([('col', pa.int8())])),
Review Comment:
```suggestion
lambda: pa.list_(pa.field(('col', pa.int8())),
```
The idea here is to change the field name of the _list_ child field (i.e.
its values), not to have a list of structs.
Compare with the default constructor:
```
In [57]: pa.list_(pa.field("elements", pa.int64()))
Out[57]: ListType(list<elements: int64>)
In [58]: pa.list_(pa.int64())
Out[58]: ListType(list<item: int64>)
```
(and to be clear, this is very much a corner case, not many people will
manually change the name of the list field, as it is otherwise not really used.
But _if_ it is set, we should try to preserve it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
