alamb commented on code in PR #2942:
URL: https://github.com/apache/arrow-rs/pull/2942#discussion_r1014088610
##########
parquet/src/column/writer/mod.rs:
##########
@@ -569,11 +569,13 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
//
// In such a scenario the dictionary decoder may return an estimated
encoded
// size in excess of the page size limit, even when there are no
buffered values
- if self.encoder.num_values() == 0 {
+ if self.page_metrics.num_buffered_values == 0 {
Review Comment:
I am not quite sure what bug you are referring to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
