alamb commented on code in PR #4095: URL: https://github.com/apache/arrow-datafusion/pull/4095#discussion_r1014224252
########## datafusion/core/src/catalog/listing_schema.rs: ########## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! listing_schema contains a SchemaProvider that scans ObjectStores for tables automatically +use crate::catalog::schema::SchemaProvider; +use crate::datasource::datasource::TableProviderFactory; +use crate::datasource::TableProvider; +use datafusion_common::DataFusionError; +use futures::TryStreamExt; +use object_store::ObjectStore; +use std::any::Any; +use std::collections::{HashMap, HashSet}; +use std::path::Path; +use std::sync::{Arc, Mutex}; + +/// A `SchemaProvider` that scans an `ObjectStore` to automatically discover tables +/// +/// A subfolder relationship is assumed, i.e. given: +/// authority = s3://host.example.com:3000 +/// path = /data/tpch +/// factory = `DeltaTableFactory` +/// +/// A table called "customer" will be registered for the folder: +/// s3://host.example.com:3000/data/tpch/customer +/// +/// assuming it contains valid deltalake data, i.e: +/// s3://host.example.com:3000/data/tpch/customer/part-00000-xxxx.snappy.parquet +/// s3://host.example.com:3000/data/tpch/customer/_delta_log/ +pub struct ListingSchemaProvider { + authority: String, + path: object_store::path::Path, + factory: Arc<dyn TableProviderFactory>, + store: Arc<dyn ObjectStore>, + tables: Arc<Mutex<HashMap<String, Arc<dyn TableProvider>>>>, +} + +impl ListingSchemaProvider { + /// Create a new `ListingSchemaProvider` + /// + /// Arguments: Review Comment: ❤️ ########## datafusion/core/src/config.rs: ########## @@ -245,11 +251,22 @@ impl BuiltInConfigs { rule. When set to false, any rules that produce errors will cause the query to fail.", true ), - ConfigDefinition::new_u64( - OPT_OPTIMIZER_MAX_PASSES, - "Number of times that the optimizer will attempt to optimize the plan", - 3 - )] + ConfigDefinition::new_u64( + OPT_OPTIMIZER_MAX_PASSES, + "Number of times that the optimizer will attempt to optimize the plan", + 3 + ), + ConfigDefinition::new_string( + OPT_CATALOG_LOCATION, + "Location scanned to load tables for `default` schema", + "".to_string() + ), + ConfigDefinition::new_string( + OPT_CATALOG_TYPE, + "Type of `TableProvider` to use when loading `default` schema", Review Comment: ```suggestion "Type of `TableProvider` to use when loading `default` schema. Defaults to None", ``` ########## datafusion/core/src/config.rs: ########## @@ -245,11 +251,22 @@ impl BuiltInConfigs { rule. When set to false, any rules that produce errors will cause the query to fail.", true ), - ConfigDefinition::new_u64( - OPT_OPTIMIZER_MAX_PASSES, - "Number of times that the optimizer will attempt to optimize the plan", - 3 - )] + ConfigDefinition::new_u64( + OPT_OPTIMIZER_MAX_PASSES, + "Number of times that the optimizer will attempt to optimize the plan", + 3 + ), + ConfigDefinition::new_string( + OPT_CATALOG_LOCATION, + "Location scanned to load tables for `default` schema", + "".to_string() Review Comment: I wonder if using `None here would be better than an empty string? ########## datafusion/core/src/config.rs: ########## @@ -245,11 +251,22 @@ impl BuiltInConfigs { rule. When set to false, any rules that produce errors will cause the query to fail.", true ), - ConfigDefinition::new_u64( - OPT_OPTIMIZER_MAX_PASSES, - "Number of times that the optimizer will attempt to optimize the plan", - 3 - )] + ConfigDefinition::new_u64( + OPT_OPTIMIZER_MAX_PASSES, + "Number of times that the optimizer will attempt to optimize the plan", + 3 + ), + ConfigDefinition::new_string( + OPT_CATALOG_LOCATION, + "Location scanned to load tables for `default` schema", Review Comment: ```suggestion "Location scanned to load tables for `default` schema, defaults to None", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
