tustvold commented on code in PR #3022:
URL: https://github.com/apache/arrow-rs/pull/3022#discussion_r1014551942
##########
arrow-ipc/src/compression.rs:
##########
@@ -115,50 +117,85 @@ impl CompressionCodec {
/// Compress the data in input buffer and write to output buffer
/// using the specified compression
- fn compress(&self, input: &[u8], output: &mut Vec<u8>) -> Result<()> {
+ fn compress(&self, input: &[u8], output: &mut Vec<u8>) -> Result<(),
ArrowError> {
match self {
- CompressionCodec::Lz4Frame => {
- let mut encoder = lz4::EncoderBuilder::new().build(output)?;
- encoder.write_all(input)?;
- match encoder.finish().1 {
- Ok(_) => Ok(()),
- Err(e) => Err(e.into()),
- }
- }
- CompressionCodec::Zstd => {
- let mut encoder = zstd::Encoder::new(output, 0)?;
- encoder.write_all(input)?;
- match encoder.finish() {
- Ok(_) => Ok(()),
- Err(e) => Err(e.into()),
- }
- }
+ CompressionCodec::Lz4Frame => compress_lz4(input, output),
+ CompressionCodec::Zstd => compress_zstd(input, output),
}
}
/// Decompress the data in input buffer and write to output buffer
/// using the specified compression
- fn decompress(&self, input: &[u8], output: &mut Vec<u8>) -> Result<usize> {
- let result: Result<usize> = match self {
- CompressionCodec::Lz4Frame => {
- let mut decoder = lz4::Decoder::new(input)?;
- match decoder.read_to_end(output) {
- Ok(size) => Ok(size),
- Err(e) => Err(e.into()),
- }
- }
- CompressionCodec::Zstd => {
- let mut decoder = zstd::Decoder::new(input)?;
- match decoder.read_to_end(output) {
- Ok(size) => Ok(size),
- Err(e) => Err(e.into()),
- }
- }
- };
- result
+ fn decompress(
+ &self,
+ input: &[u8],
+ output: &mut Vec<u8>,
+ ) -> Result<usize, ArrowError> {
+ match self {
+ CompressionCodec::Lz4Frame => decompress_lz4(input, output),
+ CompressionCodec::Zstd => decompress_zstd(input, output),
+ }
}
}
+#[cfg(feature = "lz4")]
Review Comment:
We now have separate features for the different compression codecs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
