avantgardnerio commented on code in PR #4112:
URL: https://github.com/apache/arrow-datafusion/pull/4112#discussion_r1014661828
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -141,7 +141,13 @@ mod tests {
assert!(err.to_string().contains("Generic S3 error: Missing region"));
env::set_var("AWS_REGION", "us-east-1");
- assert!(provider.get_by_url(&Url::from_str(s3).unwrap()).is_ok());
+ let url = Url::from_str(s3).expect("Unable to parse s3 url");
+ let res = provider.get_by_url(&url);
+ let msg = match res {
+ Err(e) => format!("{}", e),
+ Ok(_) => "".to_string()
+ };
+ assert_eq!("".to_string(), msg); // Fail with error message
Review Comment:
I refactored this test to have a better failure message because it was
failing for me locally. The fact that CI passed makes me think it's not running
there because `datafusion-cli` is excluded from the workspace - I don't know
why this is, but would propose we include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
