marioloko commented on PR #3013: URL: https://github.com/apache/arrow-rs/pull/3013#issuecomment-1304659409
With this last change we remove `CodecOptions` from public API by wrapping it into a more general `ReaderProperties`. # Commit description: This commits hides `CodecOptions` from the public API. The changes are the following: - Added a new structs to public API `ReaderProperties`, `ReaderPropertiesBuilder` and `ReaderPropertiesPtr` to store inmutable reader config, as it is the case of `CodecOptions`. - Removed `SerializedRowGroupReaderOptions`, `SerializedRowGroupReaderOptionsBuilder`, `SerializedPageReaderOptionsBuilder` and `SerializedPageReaderOptions`. They are not required anymore as `SerializedRowGroupReader` and `SerializedRowGroupReaderOptions` use `ReaderPropertiesPtr` for configuration. - `SerializedRowGroupReader::new_with_options` renamed to `SerializedRowGroupReader::new_with_properties`. - `SerializedPageReader::new_with_options` renamed to `SerializedPageReader::new_with_properties`. - Test added for `ReaderPropertiesBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
