tustvold commented on code in PR #3033:
URL: https://github.com/apache/arrow-rs/pull/3033#discussion_r1014877921
##########
arrow-buffer/src/bigint.rs:
##########
@@ -157,7 +157,7 @@ impl i256 {
/// Create an i256 from the provided [`BigInt`] returning a bool indicating
/// if overflow occurred
- fn from_bigint_with_overflow(v: BigInt) -> (Self, bool) {
+ pub fn from_bigint_with_overflow(v: BigInt) -> (Self, bool) {
Review Comment:
I think I would prefer to add a from_f64 than expose this method, because we
may eventually want to optimise it. Bigint is very slow as it heap allocates
memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
